Fixes kit generator error #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-k9
added
bug
thestephenmarshall
approved these changes
Dec 23, 2020
jasoncypret
removed
the
breaking
jasoncypret
changed the title
|
Merging ahead of the release as this has no effect on kits or the release. |
jasoncypret
added a commit
that referenced
this pull request
Dec 23, 2020
This reverts commit d7ae698.
jasoncypret
added a commit
that referenced
this pull request
Dec 23, 2020
thestephenmarshall
pushed a commit
that referenced
this pull request
Jan 6, 2021
thestephenmarshall
pushed a commit
that referenced
this pull request
Jan 6, 2021
thestephenmarshall
added a commit
that referenced
this pull request
Jan 7, 2021
* fixing dashboard cards * updates * Fixes genrator error (#1278) * Revert "Fixes genrator error (#1278)" (#1285) This reverts commit d7ae698. * Added fixes and style tags * Fixed React Dashobaord Cards * Fix linter errors * yarn lint fixes Co-authored-by: Andrew Kloecker <lt.kvothe@gmail.com> Co-authored-by: Jason Cypret <jason@jasoncypret.com> Co-authored-by: Stephen Marshall <smarshall1980@gmail.com>
thestephenmarshall
pushed a commit
that referenced
this pull request
Jan 7, 2021
* Fixes genrator error (#1278) * Revert "Fixes genrator error (#1278)" (#1285) This reverts commit d7ae698. * Add mobile search bar * Move mobile search to sidebar, updated styles * Clean up erb * Move mobile search back to top nav, make desktop vs mobile ids more explicit, add search bar null value handling * Fix visual guidelines dark text * Unify sidebar and navbar page titles * Switched sample active trigger to action_name from current_page Co-authored-by: Andrew Kloecker <lt.kvothe@gmail.com> Co-authored-by: Jason Cypret <jason@jasoncypret.com>
thestephenmarshall
pushed a commit
that referenced
this pull request
Jan 7, 2021
* Fixes genrator error (#1278) * Revert "Fixes genrator error (#1278)" (#1285) This reverts commit d7ae698. * Add Props to Background Kits * Add Props to Bar Graph Kit * Add Props to Circle Chart React Kits * Move Props to Top of Date React Kits * Add Props to Date Picker React Kits * Move Props to bottom instead of top * Add Props to Date React Kits * Add Props to Distribution Bar & File Upload Kits * Add Props to Filter Kit React Examples * Add Props to Fixed Confirmation Toast Kit React Examples * Add Props to PlayBook Flex Kit React Examples * Add Props to Form Pill Kit React Examples * Add Props to PlayBook Gauge Kits & Their React Examples * Update Generator Template * Update Props to Filter Kit React Examples * Add Props to Highlight Default Kit React Example * Add Props to Home Address Street Kit React Examples * Add Props to PlayBook Icon Kit React Examples * Add Props to PB Icon Circle Kit React Examples * Add Props to PB Icon State Value Kit React Examples * Update Highlight Default JSX File to fix error * Add Props to PB Icon Value Kit React Examples * Add Props to PB Image Kit React Examples * Add Props to PB Label Pill Kit React Examples * Add Props to PB Label Value Kit React Examples * Add Props to PB Layout Kit React Examples * Add Props to PB Legend Kit React Examples * Add Props to PB Line Graph React Kit Examples * Add Props to PB List Kit React Examples * Add Props PB Radio Kit React Examples * Add Props to PB Select Kit React Examples * Add Props to PB Selectable Icon Kit React Examples * Fix PB List Default React Example * Add Props to PB Selectable Card Icon Kit React Examples * Add Props to PB Selectable Icon Kit React Examples * Add Props to PB Selectable List Kit React Examples * Add Props to PB Text Input Kit React Examples * Add Props to PB TextArea Kit React Examples * Add Props to PB TypeAhead Kit React Examples * Add Props to PB Multiple Users Kit React Examples * Add Props to PB Multiple Users Stacked Kit React Examples * Add Props to PB Nav Kit React Examples * Add Props to PB PopOver Kit React Examples * Add Props to PB RichTextEditor Kit React Examples * Add Props to PB Source Kit React Examples * Add Props to PB Star Rating Kit React Examples * Add Props to PB Stat Change Kit React Examples * Add Props to PB Table Kit React Examples * Add MORE Props to PB Table Kit React Examples * Add Props to PB TimeLine Kit React Examples * Add Props to PB Title Kit React Examples * Add Props to PB Message Kit React Examples * Add Props to PB Person Kit React Examples * Add Props to PB PersonContact Kit React Examples * Add Props to PB StatValue * Add more Props to PB TimeStamp Kit React Examples * Add Props to PB TimeRangeInline Kit React Examples * Add Props to PB TitleCount Kit React Examples * Add Props to PB TitleDetail Kit React Examples * Add Props to PB WeekdayStacked Kit React Examples * Add Props to PB User Kit React Examples * Add Props to PB LoadingInline Kit React Examples * Add MORE Props to PB Background Kit React Examples Co-authored-by: Andrew Kloecker <lt.kvothe@gmail.com> Co-authored-by: Jason Cypret <jason@jasoncypret.com>
jasperfurniss
pushed a commit
that referenced
this pull request
Jan 15, 2021
* Fixes genrator error (#1278) * Revert "Fixes genrator error (#1278)" (#1285) This reverts commit d7ae698. * Exporing ideas * Still WIP * Checkbox working Radio WIP * Fix radio Use ref to delegate clicks on visible input to hidden one * Finish react side * Start rails side * Fix class/name for label * Separator to use CSS not props Works for rails and react, so removed react separatorClass function * Work on rails js * Rails checkboxes working * Finsih rails inputs * Refactor rails * Add spec coverage Co-authored-by: Andrew Kloecker <lt.kvothe@gmail.com> Co-authored-by: Jason Cypret <jason@jasoncypret.com> Co-authored-by: Stephen McKeon <stephen.mckeon@powerhrg.com>
thestephenmarshall
pushed a commit
that referenced
this pull request
Jan 15, 2021
* Fixes genrator error (#1278) * Revert "Fixes genrator error (#1278)" (#1285) This reverts commit d7ae698. * Exporing ideas * Still WIP * Checkbox working Radio WIP * Fix radio Use ref to delegate clicks on visible input to hidden one * Finish react side * Start rails side * Fix class/name for label * Separator to use CSS not props Works for rails and react, so removed react separatorClass function * Work on rails js * Rails checkboxes working * Finsih rails inputs * Refactor rails * Add spec coverage Co-authored-by: Andrew Kloecker <lt.kvothe@gmail.com> Co-authored-by: Jason Cypret <jason@jasoncypret.com> Co-authored-by: Stephen McKeon <stephen.mckeon@powerhrg.com>
jasperfurniss
pushed a commit
that referenced
this pull request
Jan 15, 2021
* Fixes genrator error (#1278) * Revert "Fixes genrator error (#1278)" (#1285) This reverts commit d7ae698. * Update kit to be consistent with spacing props * Use buffer div to account for border growth * Remove unintentional addition * Fix dark issue for selectable kit * Respect dark prop on wrapper div * Examples to respect dark prop * Use different pattern for dark check * Fix selector in selectable card icon * Change examples to function component instead of class * Missed an example Co-authored-by: Andrew Kloecker <lt.kvothe@gmail.com> Co-authored-by: Jason Cypret <jason@jasoncypret.com>
jasperfurniss
added a commit
that referenced
this pull request
Jan 15, 2021
* Fixes genrator error (#1278) * Revert "Fixes genrator error (#1278)" (#1285) This reverts commit d7ae698. * Add container as global prop react * Fix lint errors * Add global max width prop rails * Add max width to visual guidelines page * Update usage wording and add bylines in kits for max width * FIx missing comma * Add break between sentances * Delete playbook.css * Removed playbook.css change that snuck into this PR Co-authored-by: Andrew Kloecker <lt.kvothe@gmail.com> Co-authored-by: Jason Cypret <jason@jasoncypret.com> Co-authored-by: Jasper Furniss <jasper.furniss@powerhrg.com>
thestephenmarshall
pushed a commit
that referenced
this pull request
Jan 19, 2021
* Fixes genrator error (#1278) * Revert "Fixes genrator error (#1278)" (#1285) This reverts commit d7ae698. * Exporing ideas * Still WIP * Checkbox working Radio WIP * Fix radio Use ref to delegate clicks on visible input to hidden one * Finish react side * Start rails side * Fix class/name for label * Separator to use CSS not props Works for rails and react, so removed react separatorClass function * Work on rails js * Rails checkboxes working * Finsih rails inputs * Refactor rails * Add spec coverage Co-authored-by: Andrew Kloecker <lt.kvothe@gmail.com> Co-authored-by: Jason Cypret <jason@jasoncypret.com> Co-authored-by: Stephen McKeon <stephen.mckeon@powerhrg.com>
thestephenmarshall
pushed a commit
that referenced
this pull request
Jan 19, 2021
* Fixes genrator error (#1278) * Revert "Fixes genrator error (#1278)" (#1285) This reverts commit d7ae698. * Update kit to be consistent with spacing props * Use buffer div to account for border growth * Remove unintentional addition * Fix dark issue for selectable kit * Respect dark prop on wrapper div * Examples to respect dark prop * Use different pattern for dark check * Fix selector in selectable card icon * Change examples to function component instead of class * Missed an example Co-authored-by: Andrew Kloecker <lt.kvothe@gmail.com> Co-authored-by: Jason Cypret <jason@jasoncypret.com>
thestephenmarshall
pushed a commit
that referenced
this pull request
Jan 19, 2021
* Fixes genrator error (#1278) * Revert "Fixes genrator error (#1278)" (#1285) This reverts commit d7ae698. * Add container as global prop react * Fix lint errors * Add global max width prop rails * Add max width to visual guidelines page * Update usage wording and add bylines in kits for max width * FIx missing comma * Add break between sentances * Delete playbook.css * Removed playbook.css change that snuck into this PR Co-authored-by: Andrew Kloecker <lt.kvothe@gmail.com> Co-authored-by: Jason Cypret <jason@jasoncypret.com> Co-authored-by: Jasper Furniss <jasper.furniss@powerhrg.com>
kre8sions
pushed a commit
that referenced
this pull request
Feb 25, 2021
* Cleanup playbook configs (#1243) * Remove environment configs shipped along with the library * Remove unused configuration files * Remove duplicated/unnecessary/misplaced initializers * Extract markdown template handler * Move other initializers to playbook dummy app * 7.13.0 * Specifying Node Version for Github Actions (#1315) * Allow React Filter kit popover to be closed (#1303) * Fix missing CSS rule on radio kit (#1311) Co-authored-by: Jasper Furniss <jasper.furniss@powerhrg.com> * Add object fit cover to image kit (#1309) * Create a prop that allows the card kit to use border radius variables (#1306) * Add a square corners prop to card kit * Create a more encompassing border radius prop * Fix lint errors * Add more info to the docs * [NUXE-376] Add padding to Typeahead Kit when it expands to two lines (#1302) * Add margin so that typeaheads stack nice * Fix lint errors * Move margin to form pill kit and make it smaller * Fix wrong code * Change spacing around pills * Add overflow auto to card kit scss (#1300) * Custom options for typeahead kit (#1287) * Fix TypeaheadWithPillsAsync kit * Starts adding typeahead custom options * Clean up code * Remove console log * Adds md file * Starts fixing lint errors * Fix lint error defining props * Adds avatar flag * Fix merge conflict Co-authored-by: Rodolfo Santos <rodolfo.santos@powerhrg.com> * [CMPN-351] Checkbox-on-selectable-card (#1292) * Fixes genrator error (#1278) * Revert "Fixes genrator error (#1278)" (#1285) This reverts commit d7ae698. * Exporing ideas * Still WIP * Checkbox working Radio WIP * Fix radio Use ref to delegate clicks on visible input to hidden one * Finish react side * Start rails side * Fix class/name for label * Separator to use CSS not props Works for rails and react, so removed react separatorClass function * Work on rails js * Rails checkboxes working * Finsih rails inputs * Refactor rails * Add spec coverage Co-authored-by: Andrew Kloecker <lt.kvothe@gmail.com> Co-authored-by: Jason Cypret <jason@jasoncypret.com> Co-authored-by: Stephen McKeon <stephen.mckeon@powerhrg.com> * rails complete * fixed failing specs and did react * Cleanup * Not sure how/when these changes got here Co-authored-by: Carlos Palhares <carlos.palhares@powerhrg.com> Co-authored-by: Stephen Marshall <smarshall1980@gmail.com> Co-authored-by: Jasper Furniss <jasperfurniss@gmail.com> Co-authored-by: Neil L. Decapia <neil.decapia@powerhrg.com> Co-authored-by: Diego Borges <drborges.cic@gmail.com> Co-authored-by: Jasper Furniss <jasper.furniss@powerhrg.com> Co-authored-by: Josephine Fischer <64423298+josephinef9@users.noreply.github.com> Co-authored-by: Katherine Muedas <muedasnka@gmail.com> Co-authored-by: Rodolfo Santos <rodolfo.santos@powerhrg.com> Co-authored-by: Patrick McClernan <patmccler@gmail.com> Co-authored-by: Andrew Kloecker <lt.kvothe@gmail.com> Co-authored-by: Jason Cypret <jason@jasoncypret.com> Co-authored-by: Stephen McKeon <stephen.mckeon@powerhrg.com>
jasperfurniss
added a commit
that referenced
this pull request
Mar 10, 2021
* Latest * Removed QAWolf * Latest for Dialog * Starting RB * Fixes genrator error (#1278) * Revert "Fixes genrator error (#1278)" (#1285) This reverts commit d7ae698. * Latest for Rails Modal * Fixing Import * Latest * Latest * Latest * Testing Dialog for Rails * Latest * Latest * Latest for Dialog * SCSS Cleanup * More Cleanup * Fixing Indentation Co-authored-by: Andrew Kloecker <lt.kvothe@gmail.com> Co-authored-by: Jason Cypret <jason@jasoncypret.com>
jasoncypret
added a commit
that referenced
this pull request
Mar 19, 2021
* Cleanup playbook configs (#1243) * Remove environment configs shipped along with the library * Remove unused configuration files * Remove duplicated/unnecessary/misplaced initializers * Extract markdown template handler * Move other initializers to playbook dummy app * 7.13.0 * Specifying Node Version for Github Actions (#1315) * Allow React Filter kit popover to be closed (#1303) * Fix missing CSS rule on radio kit (#1311) Co-authored-by: Jasper Furniss <jasper.furniss@powerhrg.com> * Add object fit cover to image kit (#1309) * Create a prop that allows the card kit to use border radius variables (#1306) * Add a square corners prop to card kit * Create a more encompassing border radius prop * Fix lint errors * Add more info to the docs * [NUXE-376] Add padding to Typeahead Kit when it expands to two lines (#1302) * Add margin so that typeaheads stack nice * Fix lint errors * Move margin to form pill kit and make it smaller * Fix wrong code * Change spacing around pills * Add overflow auto to card kit scss (#1300) * Custom options for typeahead kit (#1287) * Fix TypeaheadWithPillsAsync kit * Starts adding typeahead custom options * Clean up code * Remove console log * Adds md file * Starts fixing lint errors * Fix lint error defining props * Adds avatar flag * Fix merge conflict Co-authored-by: Rodolfo Santos <rodolfo.santos@powerhrg.com> * [CMPN-351] Checkbox-on-selectable-card (#1292) * Fixes genrator error (#1278) * Revert "Fixes genrator error (#1278)" (#1285) This reverts commit d7ae698. * Exporing ideas * Still WIP * Checkbox working Radio WIP * Fix radio Use ref to delegate clicks on visible input to hidden one * Finish react side * Start rails side * Fix class/name for label * Separator to use CSS not props Works for rails and react, so removed react separatorClass function * Work on rails js * Rails checkboxes working * Finsih rails inputs * Refactor rails * Add spec coverage Co-authored-by: Andrew Kloecker <lt.kvothe@gmail.com> Co-authored-by: Jason Cypret <jason@jasoncypret.com> Co-authored-by: Stephen McKeon <stephen.mckeon@powerhrg.com> * rails complete * fixed failing specs and did react * Cleanup * Not sure how/when these changes got here Co-authored-by: Carlos Palhares <carlos.palhares@powerhrg.com> Co-authored-by: Stephen Marshall <smarshall1980@gmail.com> Co-authored-by: Jasper Furniss <jasperfurniss@gmail.com> Co-authored-by: Neil L. Decapia <neil.decapia@powerhrg.com> Co-authored-by: Diego Borges <drborges.cic@gmail.com> Co-authored-by: Jasper Furniss <jasper.furniss@powerhrg.com> Co-authored-by: Josephine Fischer <64423298+josephinef9@users.noreply.github.com> Co-authored-by: Katherine Muedas <muedasnka@gmail.com> Co-authored-by: Rodolfo Santos <rodolfo.santos@powerhrg.com> Co-authored-by: Patrick McClernan <patmccler@gmail.com> Co-authored-by: Andrew Kloecker <lt.kvothe@gmail.com> Co-authored-by: Jason Cypret <jason@jasoncypret.com> Co-authored-by: Stephen McKeon <stephen.mckeon@powerhrg.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screens
Breaking Changes
fixes broken generator kit from this darkmode pr
Runway Ticket URL
NUXE-378
How to test this
Run the kit generator command, possibly check dark-mode on some kits?